feat: add greet helper and document Sonar quality gate #1

2026-08-06T13:49:39-03:00

andreferraro commented

2026-08-06 13:49:39 -03:00

Summary

Adds greet() helper in hello.py
Documents Sonar quality gate in README + badge

Test plan

Gitea Actions Sonar job passes on this PR
python hello.py prints greeting
Merge into develop only after Sonar status check is green

## Summary - Adds `greet()` helper in `hello.py` - Documents Sonar quality gate in README + badge ## Test plan - [ ] Gitea Actions Sonar job passes on this PR - [ ] `python hello.py` prints greeting - [ ] Merge into `develop` only after Sonar status check is green

andreferraro added 1 commit 2026-08-06 13:49:39 -03:00

feat: add greet helper and document Sonar quality gate

sonar / sonar (push) Skipped

sonar / sonar (pull_request) Successful in 28s

Details

7b73b8a876

Co-authored-by: Cursor <cursoragent@cursor.com>

andreferraro merged commit 65ad31ea20 into develop

2026-08-06 13:50:30 -03:00

andreferraro commented

2026-08-06 14:01:25 -03:00

/review

andreferraro commented

2026-08-06 14:02:15 -03:00

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 Security concerns

Sensitive information exposure:
The SonarQube badge URL in README.md contains an authentication token (token=sqb_4b948ba1389feb0284d7d2630171396ed00b4478) exposed directly in the repository. Anyone with access to the repository can use this token to query the SonarQube API, potentially accessing project metrics or other data. The token should be removed from the URL and injected via environment variables or a CI secret.

⚡ Recommended focus areas for review

Possible Issue

The main() function is defined twice in the file (lines 9 and 14). The second definition at line 14 will overwrite the first, so the print(greet()) call added at line 10 will never execute. Running python hello.py will print nothing because the second main() (which has no body) is the one that runs.

def main() -> None:
    print(greet())


if __name__ == "__main__":
    main()

## PR Reviewer Guide 🔍 Here are some key observations to aid the review process: <table> <tr><td>⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪</td></tr> <tr><td>🧪 No relevant tests</td></tr> <tr><td>🔒 Security concerns Sensitive information exposure: The SonarQube badge URL in README.md contains an authentication token (`token=sqb_4b948ba1389feb0284d7d2630171396ed00b4478`) exposed directly in the repository. Anyone with access to the repository can use this token to query the SonarQube API, potentially accessing project metrics or other data. The token should be removed from the URL and injected via environment variables or a CI secret.</td></tr> <tr><td>⚡ Recommended focus areas for review <details><summary><a href='https://gitea.app.andreferraro.com/andreferraro/TicketLab_MCP/src/branch/feature/greet-ticketlab/hello.py#L9-L14'>Possible Issue</a> The `main()` function is defined twice in the file (lines 9 and 14). The second definition at line 14 will overwrite the first, so the `print(greet())` call added at line 10 will never execute. Running `python hello.py` will print nothing because the second `main()` (which has no body) is the one that runs. </summary> ```python def main() -> None: print(greet()) if __name__ == "__main__": main() ``` </details> </td></tr> </table>

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: andreferraro/TicketLab_MCP#1